Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set up basic website and catalog apps (#4) #11

Merged
merged 12 commits into from
Aug 29, 2024
Merged

feat: set up basic website and catalog apps (#4) #11

merged 12 commits into from
Aug 29, 2024

Conversation

hunterckx
Copy link
Collaborator

@hunterckx hunterckx commented Aug 29, 2024 •
edited by MillenniumFalconMechanic
Loading

Ticket:
Closes #4.

Notes:

  • The website consists of an extremely minimal home page
  • The catalog consists of an entity list based on placeholder data
    • I don't actually know what exactly the entities we'll be listing represent; I've called them "genomes"

@dannon
Fix PUBLIC_DIR creation when run in a new repo -- public won't exist and
4452f5b 
we need to create /public/ as well as /public/favicons/
MillenniumFalconMechanic
MillenniumFalconMechanic approved these changes Aug 29, 2024
View reviewed changes
Copy link

@MillenniumFalconMechanic MillenniumFalconMechanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Hunter!

@MillenniumFalconMechanic MillenniumFalconMechanic merged commit 8661914 into main Aug 29, 2024
1 check passed
@MillenniumFalconMechanic MillenniumFalconMechanic deleted the hunter/4-set-up-apps branch August 29, 2024 17:14
@github-actions github-actions bot mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MillenniumFalconMechanic MillenniumFalconMechanic MillenniumFalconMechanic approved these changes

Assignees

@MillenniumFalconMechanic MillenniumFalconMechanic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up website and catalog applications
3 participants
@hunterckx @MillenniumFalconMechanic @dannon